gossipd: tell lightningd about all our previous channel_updates at startup - #6456
Merged
rustyrussell merged 1 commit intoJul 29, 2023
Merged
Conversation
rustyrussell
force-pushed
the
help-empty-updates
branch
from
July 28, 2023 05:36
83a6d67 to
59b15b1
Compare
…artup. This will at least *help* the case where these were not populated, causing us to send errors without channel_updated appended. It's not perfect: we can still send such errors if the gossip store is corrupted, and we still send them for private channels, but it should help. (The much better fix is far more invasive, so slips to next release!) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
endothermicdev
force-pushed
the
help-empty-updates
branch
from
July 28, 2023 21:27
59b15b1 to
0b569e7
Compare
endothermicdev
approved these changes
Jul 28, 2023
endothermicdev
left a comment
endothermicdev
left a comment
Collaborator
There was a problem hiding this comment.
Pushed a spelling fix in the csv comment.
ACK 0b569e7
Contributor
|
Testing #6253 yesterday I found a number of cases of “this node is surprised at the spend state of its own spliced channel at startup”. I wonder if it’s related to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will at least help the case where these were not populated, causing us to send errors without channel_updated appended.
It's not perfect: we can still send such errors if the gossip store is corrupted, and we still send them for private channels, but it should help.
(The much better fix is far more invasive, so slips to next release!)
See: #5822